Skip to content
Snippets Groups Projects

search: Fix React errors about unsupported DOM props

Merged Warren Gifford requested to merge fkling/search-input-errors into main

Created by: fkling

#36204 added a change to add all "rest" props to a <div> element, which had the effect that a lot of component specific props have been added to the DOM element, and React complains about that (there are ~ 70 errors about that):

2022-06-09_09-54

This commit fixes this in two ways: Only the props required by <Toggles> are passed and the rest props spread is removed (it's not clear to me why this was needed in the first place).

Test plan

Loaded https://sourcegraph.test:3443/search and the errors were gone.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading