Skip to content

Revert "JetBrains: Manually emit window closing/open events to fix third-party modules that rely on those to render overlays (#36699)

Warren Gifford requested to merge ps/revert-jetbrains-fix-material-ui-bug into main

Created by: philipp-spiess

This reverts commit 6fc0c2de01c1746fd3402ab277ffe0cdac38c439.

Unfortunately this change brought back the weird behavior where the web view is somehow brought into an unknown state (we assume it is related to offscreen rendering) where, on MacOS, it bugs out and becomes unusable. It seems like the WINDOW_CLOSING event is tied to garbage collection there somehow.

cc @mallowigi: It seems like we can not do what we tried to do here 🙁 I suggest that we add a small event listener in the material theme that detects when the main project is gaining focus. This should be a safe mechanism to turn off the overlay in any scenario. What do you think? If you give me access to the repo, I’m happy to contribute.

Test plan

  • Tested manually
  • @vdavid please also test on your machine

App preview:

Check out the client app preview documentation to learn more.

Merge request reports