[SG-36338] Wildcard <Icon /> accessibility, Default role="img"
Created by: gitstart-sourcegraph
Description
In order to split the Icon accessibility efforts into smaller PRs, we've had to remove the default prop role="img"
from the wildcard's icon component.
Ref
Acceptance criteria
-
We now have img
set as default role, within the wildcards's Icon component.
Time estimate
- Pull requests with frontend lines changed should take 2 hours at maximum. Ping the reviewer in the spec pull request if time-consuming changes are required.
- Split the work into multiple pull requests if the total diff is bigger than 450 lines of code.
Implementation Detail
- Make role prop default to img within the wildcard component
- we have ensured to follow this order during migration
<Icon role="img" ... />
i.e use the find and replace tool (on vscode or any other editor), to find every usage instance of<Icon role="img"
and replace with<Icon
Test Plan
Ensure there are no UI changes on both storybook and application
App preview:
Check out the client app preview documentation to learn more.