Skip to content
Snippets Groups Projects

[SG-35158] Accessibility: Code monitoring logs: wrong usage of heading elements

Merged Warren Gifford requested to merge contractors/SG-35158 into main

Created by: gitstart-sourcegraph

Audit type

ARC Toolkit

User journey audit issue

#34194

Problem description

Expected behavior

  • "Code Monitoring" header is an h2

  • "MONITOR NAME" & "LAST RUN" elements should be styled as h5, but implemented using div or span with aria-hidden="true" so that they do not appear for screen readers.

Refs

Sourcegraph Issue Gitstart Ticket

Description: Short description about changes on this PR

  • Changed "Code Monitoring" header from H1 (default) to an H2

  • Implemented "MONITOR NAME" & "LAST RUN" elements using span with aria-hidden="true" so that they do not appear for screen readers

Test plan

  • "Code Monitoring" header should be an h2

  • "MONITOR NAME" & "LAST RUN" elements shouldn't appear for screen readers

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Merged by avatar (Apr 23, 2025 6:09pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading