Skip to content

search: try unordered patterns in lucky search

Warren Gifford requested to merge rvt/lucky-search-more into main

Created by: rvantonder

This adds a rule to automatically try and-ed terms after trying ordered terms. After this rule, I think the mode is "shippable" 😄 Because our two biggest areas of friction are

  • "is my pattern ordered or unordered and also even though I understand it I don't want to write AND everytime when I prefer AND"
  • "why is it searching for quotes literally"

Implementation note:

The two current rules are orthogonal, meaning they could compose. E.g., "try unquote a patterns, if that succeeds, also try unorder them". Right now though, I'm keeping them separate (only try unquote patterns and search, then try unorder the patterns (without also unquoting) and search. This because I or others can always work on better ways to allow rules to compose, but my focus is to make this shippable, and I want to make sure we surface some informative alerts, before mucking more with rule composition.

Test plan

Added a test.

Merge request reports

Loading