Skip to content

Fix highlighting fallback to plain text on error

Warren Gifford requested to merge es/fix-highlighting into main

Created by: eseliger

I was wondering why I increasingly often saw highlighting errors in the past few weeks. I've pinned it down to these lines, somehow the return values seem to have gotten mixed up. We now properly return plain text results and aborted: true, and only return errors when we hard failed (like anticipated by the PR, afaict).

Test plan

Tested locally that the issue I was seeing where highlighting would often hard fail no longer happens.

Merge request reports

Loading