Skip to content

codemirror: Fix aria-label for search query input

Warren Gifford requested to merge fkling/fix-queryinput-aria-label into main

Created by: fkling

In #36308 GitStart added 'aria-label' by mutating the DOM but the documentation explicitly says that this shouldn't be done. Using the EditorView.contentAttributes facet is the way to go.

role='textbox' is already added by CodeMirror itself.

Test plan

Inspected the DOM Screenshot 2022-06-02 at 13 29 55

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading