[SG-34721] Accessibility: Add saved search" button on empty saved searches panel doesn't activate with spacebar

Review changes
Download
Patches
Plain diff

Merged [SG-34721] Accessibility: Add saved search" button on empty saved searches panel doesn't activate with spacebar

contractors/SG-34721 into main

Overview 1
Commits 1
Pipelines 0
Changes 1

Merged Warren Gifford requested to merge contractors/SG-34721 into main 3 years ago

Overview 1
Commits 1
Pipelines 0
Changes 1

Created by: gitstart-sourcegraph

Audit type

Keyboard navigation

User journey audit issue

https://github.com/sourcegraph/sourcegraph/issues/https://github.com/sourcegraph/sourcegraph/issues/34189

Problem description

Open Sourcegraph Server (not .com) If the saved searches panel is not empty, delete any saved searches (both own and org) Focus on the "+ Create a saved search" button Press space, observe nothing happens

Expected behavior

The button should activate

Refs

sourcegraph issue Gitstart Ticket

Test plan

Follow Problem description section above Notice that when spacebar is clicked on create a saved search the button is now activated

App preview:

Web
Storybook

Check out the client app preview documentation to learn more.

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Labels

cla-signed gitstart

Select labels

Manage project labels

Milestone

None

Time tracking

No estimate or time spent

1 Participant

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.