Skip to content

JetBrains: Don't handle alt+enter in Java if it happens inside the web view

Created by: philipp-spiess

@vdavid noticed here that the key listener restructuring caused the alt+enter keybind to always be handled in the Java code. This is because we have added the same listener code for both events from the Java side and events from the web view side.

This PR fixes this by adding a boolean argument to differentiate the two. We already have working handlers for alt+enter on the web view and it is conceptually important that the web view can handle the data that should be opened in that case because of possible data races.

Test plan

Verified that alt+enter inside the web view still works:

https://user-images.githubusercontent.com/458591/171432363-63e26f6a-4dd9-4779-8aad-28f4cebaa636.mov

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading