site_config: update editor content after loading from backend

Review changes
Download
Patches
Plain diff

Closed site_config: update editor content after loading from backend

Overview 3
Commits 1
Pipelines 0
Changes 2

Closed Warren Gifford requested to merge jc/save-site-config into main 2 years ago

Overview 3
Commits 1
Pipelines 0
Changes 2

Created by: unknwon

Upon every click of "Save changes" we are getting back the up-to-date contents for site configuration (which may or may not be the same as the current editor's content due to formatting). It creates a confusing UX that our web app keeps complaining about the inconsistent state (and offers to save again and again).

This PR updates the editor's content whenever we fetched it.

Fix for https://github.com/sourcegraph/customer/issues/979

Test plan

Manual e2e test since this is a UX issue (the license key won't work alone without its private part to be used as the validation key).

App preview:

Web
Storybook

Check out the client app preview documentation to learn more.

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Labels

cla-signed team/iam

Select labels

Manage project labels

Milestone

None

Time tracking

No estimate or time spent

2 Participants

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.