JetBrains: Improve key handlers and handle alt+enter in the preview panel (!36295) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge ps/jetbrains-key-listener-fixes into main May 31, 2022

Created by: philipp-spiess

Fixes #34893 (closed) Fixes #35920 (closed)

This PR fixes key handlers that currently sometimes get swallowed when the editor has focus. It seems that in this case, the manual swing listener never fires which leads me to believe that the editor has a custom key handling (necessary for the advanced text editing capabilities). To work around this, we now add a global key listener. However since these are global, we need to be careful to only respond to events if they happen in the right project. To do that, we check if the popover is active and shown. The test plan includes tests with two projects open side-by-side to ensure there are no issues in this setup.

Additionally, since I've restructured the key handler code in Java, it was easy for me to add support for alt+enter when the editor is in focus as well.