Skip to content

Handle changed GitHub DOM

Warren Gifford requested to merge fix-github-changed-dom into master

Created by: felixfbecker

Fixes #3577 (closed)

Changes the toolbar mount creation function and updates all fixtures.

What made this difficult was that DOM function tests rely on specific PRs to be used as fixtures, so I couldn't update them with just any PR and had to find out which one was used before. I added a comment for each file with a URL, but really we should change them to assert snapshots/selectors instead.

Test Plan

Code Hosts
  • GitHub
  • GitHub Enterprise
  • Refined GitHub
  • Phabricator
  • Phabricator integration
  • Bitbucket
  • Gitlab
Browsers
  • Chrome
  • Firefox

Merge request reports

Loading