searcher: prefix all prometheus variables with metric

Created by: keegancsmith

This is a pattern we started using a while ago, but the code in searcher predates that. This was done via gopls doing renames.

Test Plan: go test