Skip to content

chose: unify shared code between search results components and clean up

Warren Gifford requested to merge jp/unifyresults into main

Created by: limitedmage

  • Move CodeHostIcon and SearchResultStar from their duplicate location in FileSearchResult, RepoSearchResult and CommitSearchResult into ResultContainer
  • Remove redundant and unused properties
  • Remove isInContext from MatchGroup, which is written to but never read, as far as I can tell

Recommend reviewing with ignore whitespace enabled

Test plan

Refactor only, all existing tests should pass. Some snapshots were updated but there should be no visual changes.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports