Skip to content

[SG-35213] Wildcard <Icon /> accessibility: `client/web/src/batches, codeintel, communitySearchContexts, components, extensions,marketing, nav, notebooks, org, savedSearches, search, tour, tree

Warren Gifford requested to merge contractors/SG-35213 into main

Created by: gitstart-sourcegraph

Expected Behaviour

For decorative icons, we should set aria-hidden="true". This will ensure screen readers completely ignore the icon, as it adds no value to the user journey.

For icons that add useful information to the page, we should set role="img" and title="Some descriptive text". This will ensure screen readers are able to properly understand to meaning of the icon.

Implementation details

https://github.com/sourcegraph/sourcegraph/issues/34582#issuecomment-1111109339 Note: role="img" to <Icon /> would be added on following client/web/src directories:

batches codeintel communitySearchContexts components extensions marketing nav notebooks org savedSearches search tour tree

Refs

Sourcegraph Issue Gitstart Ticket

Test Plan

  • All wildcard <Icon/> in the client/web/src can be read by screen readers
  • No UI diff available

App preview:

Check out the client app preview documentation to learn more.

Merge request reports