Skip to content

Revert "compute: use authenticated endpoint via POST method"

Warren Gifford requested to merge revert-35758-rvt/compute-auth-endpoint into main

Created by: rvantonder

Reverts sourcegraph/sourcegraph#35758. Currently breaking main.

Details:

Adding POST handler somehow breaking integration test (?). Reverting so I can investigate, probably something dumb.

--- FAIL: TestCompute/stream (0.00s)
--
  | --- FAIL: TestCompute/stream/compute_endpoint_returns_results (0.00s)
  | compute_test.go:18: unexpected error: malformed event, expected event: 404 page not found
  | (1) attached stack trace
  | -- stack trace:
  | \| github.com/sourcegraph/sourcegraph/internal/search/streaming/http.(*Decoder).Scan
  | \| 	/root/buildkite/build/sourcegraph/internal/search/streaming/http/decoder.go:67
  | \| github.com/sourcegraph/sourcegraph/internal/gqltestutil.ComputeMatchContextStreamDecoder.ReadAll
  | \| 	/root/buildkite/build/sourcegraph/internal/gqltestutil/compute.go:66
  | \| github.com/sourcegraph/sourcegraph/internal/gqltestutil.(*ComputeStreamClient).Compute
  | \| 	/root/buildkite/build/sourcegraph/internal/gqltestutil/compute.go:41
  | \| github.com/sourcegraph/sourcegraph/dev/gqltest.testComputeClient.func1
  | \| 	/root/buildkite/build/sourcegraph/dev/gqltest/compute_test.go:16
  | \| testing.tRunner
  | \| 	/root/.asdf/installs/golang/1.18.1/go/src/testing/testing.go:1439
  | \| runtime.goexit
  | \| 	/root/.asdf/installs/golang/1.18.1/go/src/runtime/asm_amd64.s:1571
  | Wraps: (2) malformed event, expected event: 404 page not found
  | Error types: (1) *withstack.withStack (2) *errutil.leafError
  | compute_test.go:21: Expected results, got none

Test plan

It's a revert

Merge request reports