Skip to content

Accessibility: Alert assertiveness

Warren Gifford requested to merge tr/alert-assertiveness into main

Created by: umpox

Description

We disabled role="alert" by default in this PR: https://github.com/sourcegraph/sourcegraph/pull/35410

That fixes a lot of areas where our alerts are a bit too eager (example: loading a page for the first time, like https://sourcegraph.com/code-monitoring).

It means that we have to remember to opt-in for other valid alerts (like form submission). Instead of enforcing this, we can make it opt-out as there should (hopefully) be less problematic uses in our app.

Test plan

Tested with a screen reader in local development

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading