Skip to content

JetBrains search box fixes

Warren Gifford requested to merge dv/jetbrains-search-box-fixing into main

Created by: vdavid

Fixes https://github.com/sourcegraph/sourcegraph/issues/35171 Fixes https://github.com/sourcegraph/sourcegraph/issues/35177 Fixes https://github.com/sourcegraph/sourcegraph/issues/35172 Fixes https://github.com/sourcegraph/sourcegraph/issues/35174 Fixes https://github.com/sourcegraph/sourcegraph/issues/35176 Fixes https://github.com/sourcegraph/sourcegraph/issues/35173 Fixes https://github.com/sourcegraph/sourcegraph/issues/35175 Fixes https://github.com/sourcegraph/sourcegraph/issues/34369 (tracking issue)

When we first integrated the SearchBox component with @philipp-spiess and @tjkandala, we mocked a bunch of its parameters. In the past two weeks, I went through all the missing parts (TJ helped with the toughest ones), and wired up everything except telemetry (we can do that later, even after v1). This PR contains all the minor fixes, listed in the tracking issue.

I'm not 100% sure if everything works because I couldn't test the search context for example.

However, I don't mind if not everything works because it's not a live feature. In the code review, I just want to make sure that we discover any bugs or missing peaces there might be, and make sure each of them has an issue that we track. Once we have that, it'd be nice to merge this PR.

In the "Test plan" section below, I've listed all the aspects that are affected.

Test plan

Check the code to see if it makes sense, plus go through these features:

  • Search contexts should load, and when you select one, it should apply.
  • When changing the "case sensitivity" or "regexp pattern" or "structural search" buttons, the query should re-run
  • In case of long-running queries (e.g. structural search), old results shouldn't overwrite or mix with new ones
  • Dark/light theme should be applied to the search box (like in this Loom)
  • When you open the same project, the last search settings should load up (context, case sensitivity, regex setting, query)
  • Globbing should be enabled/disabled based on the setting in sourcegraph.xml
  • It should write "Auth: success" if your accessToken is set to a valid value in your sourcegraph.xml, and "Auth: failure" if it's not.
  • Not sure how to test this, but see if the settings cascade is loaded

App preview:

Check out the client app preview documentation to learn more.

Merge request reports