Something went wrong while fetching comments. Please try again.
Created by: camdencheek
This is a followup from https://github.com/sourcegraph/sourcegraph/pull/35241 that takes the new changes and updates the code with some renames and reorganizations that take advantage of the new structure.
Stacked on #35241
Basic summary of the changes:
query.Q > query.Basic > query.Flat
NewJob, NewBasicJob, and NewFlatJob
ToParseTree is renamed to ToQ to parallel ToBasic
NewJob so we have autogold tests that capture the full job tree rather than just a subtree.Each commit is atomic, self-describing, and passes tests.
I added a few tests and updated tests to capture the broader behavior. All the changes should be semantics-preserving and just narrow types, reorganize, or rename.