Skip to content

Refactor code view specs & code view resolvers

Warren Gifford requested to merge deprecate-code-view-specs into master

Created by: lguychard

Review by commit.

Fixes #3271 (closed), #3491 (closed)

After making the changes in https://github.com/sourcegraph/sourcegraph/pull/3488, code intelligence was still broken on this PR: https://github.com/sourcegraph/sourcegraph/pull/3471

This was due to https://github.com/sourcegraph/sourcegraph/issues/3491. The best way to fix it cleanly was to make fileLineContainerCodeView a ViewResolver. While I was at it I merged CodeHost.codeViewSpecs and CodeHost.codeViewResolver into CodeHost.codeViewResolvers: ViewResolver<CodeView>.

Test Plan

Code Hosts

  • GitHub
  • Gitlab

Browsers

  • Chrome
  • Firefox

Merge request reports