Skip to content

vsce: update search components

Warren Gifford requested to merge bee/update-vsce-test into main

Created by: abeatrix

To close: https://github.com/sourcegraph/sourcegraph/issues/34856

Summary

As mentioned in https://github.com/sourcegraph/sourcegraph/issues/34856, the new search components (CommitSearchResult and RepoSearchResult) introduced to our main branch (https://github.com/sourcegraph/sourcegraph/pull/34804) is breaking the VS Code extension as we are currently importing the old search component ( SearchResult ) that has been split into two different components (CommitSearchResult and RepoSearchResult): image

Build failed at: https://buildkite.com/sourcegraph/sourcegraph/builds/145545#76716825-de2f-4e48-a97a-ead3dbf4390a

Fix

This PR is to update the extension to use the CommitSearchResult for commit results, and RepoSearchResult for repo results, instead of the old SearchResult component for both commit and repo result that has been removed from the main branch.

Test plan

Manually tested and the test-integration, test-build, and build are currently passing:

❯ yarn test-integration

Starting VS Code {
  verbose: false,
  vscodeExecutablePath: '/Users/bee/Documents/sourcegraph/client/vscode/.vscode-test/vscode-darwin-1.66'... 49 more characters,
  userDataDirectory: '/var/folders/g1/f24vdsfn2mb1z2_wwyl5vygh0000gn/T/vscecMK0Jp',
  extensionsDirectory: '/var/folders/g1/f24vdsfn2mb1z2_wwyl5vygh0000gn/T/vsceOoysvR'
}
VSCode started in debug mode on http://127.0.0.1:29378
    ✓ works (9726ms)


  1 passing (26s)

✨  Done in 33.85s.
❯ yarn build:test
  webviews compiled in 98419 ms
[14:49:36] Finished 'webpack' after 1.63 min
✨  Done in 101.40s.
❯ yarn build

webviews:
  webviews compiled in 76423 ms
[14:51:59] Finished 'webpack' after 1.27 min
✨  Done in 78.22s.

App preview:

Check out the client app preview documentation to learn more.

Able to perform search: Screen Shot 2022-05-03 at 3 18 55 PM

Able to open repo result: Screen Shot 2022-05-03 at 3 19 40 PM

Screen Shot 2022-05-03 at 3 19 43 PM

Able to open commit results, and confirmed it's using the new CommitSearchResult component: Screen Shot 2022-05-03 at 3 20 10 PM

Screen Shot 2022-05-03 at 3 21 00 PM

Merge request reports

Loading