Skip to content

GitLab

Explore

Sign in
Register

Primary navigation

Project

S

sourcegraph
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Wiki
- Snippets
- Package registry
- Model registry
- Environments
- Terraform modules
- Incidents
- Value stream analytics
- Model experiments

Snippets Groups Projects

!3471

remove symbol resolver from file match and suggestions

Review changes
Download
Patches
Plain diff

Merged remove symbol resolver from file match and suggestions

ijsnow/search-detach-symbols into master

Overview 5
Commits 4
Pipelines 0
Changes 5

Merged remove symbol resolver from file match and suggestions

Warren Giffordrequested to merge

ijsnow/search-detach-symbols into master Apr 17, 2019

Overview 5
Commits 4
Pipelines 0
Changes 5

Created by: ijsnow

This PR decouples the symbolResolver type from search code. It does so by creating a searchSymbolResult that contains the data needed for toSymbolResolver and only uses toSymbolResolver when leaving the search portion of the graphqlbackend.

Helps with https://github.com/sourcegraph/sourcegraph/issues/3566.

Test plan: rely on existing tests and added one test

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Loading

Labels

0

None

0

None

Select labels

Manage project labels

Milestone

None

None

None

Time tracking

No estimate or time spent

1

1 Participant

There are no commits yet

Push commits to the source branch or add previously merged commits to review them.

Loading