Skip to content

fix: vsce - incorrect instance version error

Warren Gifford requested to merge bee/vsce-fix-version-error into main

Created by: abeatrix

Closes: https://github.com/sourcegraph/sourcegraph/issues/34207

Currently, errors messages regarding unsupported instance versions would pop up when you first installed the extension even if you are connected to a supported instance / cloud instance: Screen Shot 2022-04-20 at 10 29 27 AM

This is due to the displayInstanceVersionWarnings function before called before we call the function that invoke the graphQL call to retrieve the instance version number.

To resolve this, we can merge the warning display function to when we make the graphQL call, so that we can ensure the version number is ready before we can proceed to display warnings accordingly.

Test plan

Tested manually

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading