Skip to content

vscode: add experimental esbuild support

Warren Gifford requested to merge tjk/vsce-esbuild into main

Created by: tjkandala

Closes #28823 (closed)

Adds ability to build the VS Code extension with esbuild. Production build time has gone from 100 seconds to 1.5 seconds on my M1 Pro MBP! Moves and modifies experimental web esbuild plugins to work with the VS Code extension.

esbuild webpack
Screen Shot 2022-04-18 at 10 55 36 AM Screen Shot 2022-04-18 at 12 03 48 PM

Screen Shot 2022-04-18 at 10 55 22 AM

TODO:

  • ensure no regressions with integration tests (create separate issue)

Test plan

  • Steps for node extension host
    • Run yarn build:esbuild in the client/vscode directory
    • Run "Launch VS Code Extension" task in VS Code
    • Note that search and remote file browsing still work
  • Steps for webworker extension host
    • Run yarn build:esbuild:web in the client/vscode directory
    • Run "Launch VS Code Web Extension" task in VS Code
    • Note that search and remote file browsing still work

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading