web: review environment variables before the Datadog integration (!33994) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge vb/datadog-env into main Apr 18, 2022

Created by: valerybugakov

Context

As a part of the preparation for https://github.com/sourcegraph/sourcegraph/issues/33992, this PR improves documentation for the web application environment variables.

All web application environment variables are consolidated in the environment-config module to keep one source of truth.
The documentation for web application environment variables is improved.
Added ENABLE_MONITORING environment variable that will be used to enable Datadog RUM in the development environment in the follow-up pull request.
Renamed DISABLE_TELEMETRY to ENABLE_TELEMETRY to keep telemetry disabled in the development environment by default.
Renamed CLIENT_PROXY_DEVELOPMENT_PORT to SOURCEGRAPH_HTTP_PORT to keep it consistent with other webpack-dev-server environment variables.
success-banner.ts is converted to TS.

The CI should be green, and all commands for starting the web application and Storybook should behave without any changes.