Skip to content

fix: VSCE code monitor button and update save search form style

Warren Gifford requested to merge bee/vsce-fix-monitor into tjk/vsce-search-ui

Created by: abeatrix

This PR fixes the code monitor button redirect issue as mentioned in https://github.com/sourcegraph/sourcegraph/issues/33631

Currently Clicking on the Code Monitor Button as a non-signed-in user would open the sign up modal as well as the browser window to create code monitor. The expected behavior is to open the browser window if the user is signed in, and open the modal only if the user is not signed in.

In addition to the fix for the aforementioned issue, this PR also:

  • update button element for the pop up modal (now using the button element from the vscode webview kit) as we were using the wrong button color previously. Before: image After: image

  • fix the save search create form issue discussed in https://github.com/sourcegraph/sourcegraph/issues/31093 where pattern type is not imported when trying to create a new save search, resulting in error. Before: image After: image

  • update the save search create form style to match the CTA banner. Also included a dismiss button Before image After: image

Test plan

N/A for styling

Merge request reports