Skip to content

Show decorations on diff code views

Warren Gifford requested to merge diff-decorations into master

Created by: felixfbecker

Will fix #911 (closed)

  • Fix perf problems, see #3284 (closed) #3285 (closed)
  • Implement getLineElementFromLineNumber() for all code hosts
  • Implement diff decorations for the Sourcegraph webapp
  • Fix decorations not getting cleaned up
  • Add test
  • Change Codecov extension to not use transparent colors. The colors must have 100% alpha, or the diff colors will shine through, which makes it impossible to read. They should define 100% alpha colors, with different colors for light and dark. https://github.com/codecov/sourcegraph-codecov/pull/30

Possible optimization: getCodeElementFromLineElement instead of getCodeElementFromLineElement()

Outdated screenshots (background color is now applied to the whole line if Decoration.isWholeLine === true):

Old Screenshots

image

image

2019-05-29 22 03 44

Test Plan

Code Hosts
  • GitHub
  • GitHub Enterprise
  • Refined GitHub
  • Phabricator
  • Phabricator integration
  • Bitbucket
  • Gitlab
Browsers
  • Chrome
  • Firefox

Merge request reports