Skip to content

insights: Return dataSeries for frozen insights

Warren Gifford requested to merge insights/revert-freeze into main

Created by: CristinaBirkel

Description

For 3.38 we're going to ignore the isFrozen flag and want to return dataSeries points for all insights, regardless of whether or not they are frozen. The eventual plan will be to add this functionality back in.

Also returning all insights to critical telemetry instead of just frozen insights, again because we are ignoring the isFrozen flag for this release.

Test plan

For the API change, make sure to have some frozen BE insights in the database, then query for them and verify that the dataSeries points are showing up even for the frozen ones:

query {
    insightViews {
    nodes {
        isFrozen,
        id,
        dataSeries {
            points {
                value,
                dateTime
            }
        }
     }            
    }
}

For testing the critical telemetry, make sure to have some frozen insights in the database, then check the site-admin/pings page locally to see that the codeInsightsCriticalTelemetry value is what you expect.

Merge request reports