Skip to content

consistently use view component type "CodeEditor" not "textEditor"

Warren Gifford requested to merge codeeditor-not-texteditor into master

Created by: sqs

In sourcegraph.d.ts, the CodeEditor#type value is CodeEditor, but in context expressions and in the impl, the type is textEditor. This commit updates everywhere to use CodeEditor for consistency.

TODO:

  • All extensions with context expressions using the expression component.type need to be updated to check for "CodeEditor" not "textEditor" (and should be backcompat with older Sourcegraph versions, so both values should be supported and treated identically).

Merge request reports