Skip to content

sg: fix installation errors getting lost

Warren Gifford requested to merge mrn/fix-sg-install-err into main

Created by: mrnugget

One-line fix: we reported failed installations in installDone which lead to us printing "success!" even though something failed and then trying to run the post-install callback, which ran into a "context canceled" error, which would then be propagated.

Tests I added catch this.

Test plan

  • Added unit tests, tested locally

Merge request reports

Loading