Skip to content

GitLab

Explore

Sign in
Register

Primary navigation

Project

S

sourcegraph
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Wiki
- Snippets
- Package registry
- Model registry
- Environments
- Terraform modules
- Incidents
- Value stream analytics
- Model experiments

Snippets Groups Projects

!32391

Migrate BExt and IDE dismissal to temporary settings

Review changes
Download
Patches
Plain diff

Merged Migrate BExt and IDE dismissal to temporary settings

Warren Giffordrequested to merge

ps/bext-and-ide-cta-temporary-setting-2 into main Mar 9, 2022

Overview 0
Commits 1
Pipelines 0
Changes 4

Created by: philipp-spiess

This PR addresses a further issue with the current BExt and IDe CTAs: When the banner is dismissed, we will currently only store it inside localStorage. To remember this config per-user, we should instead use temporary settings (for logged out users, the behavior is the same).

Test plan

I made sure that the preference is now saved in GraphQL:

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

0 Reviewers

Request review from

Loading

Labels

0

None

0

None

Select labels

Manage project labels

Milestone

None

None

None

Time tracking

Participants

There are no commits yet

Push commits to the source branch or add previously merged commits to review them.

Loading