Skip to content
Snippets Groups Projects

Wildcard V2: <Popover /> style migration

Merged Warren Gifford requested to merge contractors/SG-27695.1 into main

Created by: gitstart-sourcegraph

Description

Manual Migrations to wildcard component, in highlighted files and components with usage of dropdown-menu

Refs

Gitstart Ticket SourceGraph Link Review Changes Loom video Parent Issue

Test Plan

  • Run web app using preview app.
  • Confirm there are no UI variations while comparing all use cases of Popover with prod environment

Preview App

Frontend Storybook

Implementation

Styles migration:

  1. Migrate usage of dropdown-menu class to Wildcard Popover
  2. Remove dropdown-menu Bootstrap dependency - reimplement styles in Popover CSS module

Note: dropdown-menu usage is also required for the Menu components. We should wait until this migration (https://github.com/sourcegraph/sourcegraph/issues/27701) is finished before migrating away from global styles.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading