Skip to content

symbols: Fix columns

Warren Gifford requested to merge symbols-fix-range into main

Created by: chrismwendt

Before

image

After

CleanShot 2022-03-07 at 19 13 18@2x
  • Made the symbols service return lines 0-based
  • Added character to the output of the symbols service
  • Adjusted back to 1-based in the frontend/backend package (lol it really is called that)
  • Dropped pattern

Resolves https://github.com/sourcegraph/sourcegraph/issues/32295

Depends on https://github.com/sourcegraph/sourcegraph/pull/32300

There's another issue that seems relevant https://github.com/sourcegraph/sourcegraph/pull/23664 @rvantonder am I missing something here?

The indexed search query path still seems to work:

CleanShot 2022-03-07 at 19 32 37

Test plan

Ran locally, also added a test.

Merge request reports

Loading