Skip to content

pkg/tracer: allow Jaeger to be configured via standard JAEGER_* env vars

Warren Gifford requested to merge sg/jaeger-env into master

Created by: slimsag

Prior to this change it was not possible to configure the Jaeger client using the standard JAEGER_* env vars.

After this change, behavior remains the same for all Jaeger users except JAEGER_* env vars are now respected.

Without this change, it is impossible to configure Sourcegraph services to communicate with a jaeger-agent running on the same host machine in the case of deploy-sourcegraph-docker because the loopback interface does not work to communicate with same-host containers there (while it does on Kubernetes), i.e. we must use their actual domain name like jaeger-agent.

Helps #2873 (closed)

Test plan: Visual logic verification + manual post-merge testing

Merge request reports