Skip to content

Experimental ref panel: restore click2j2d behaviour

Warren Gifford requested to merge mrn/url-based-ref-panel into main

Created by: mrnugget

This fixes #31642 (closed) by reverting to the old behaviour of the reference panel and only opening it when clicking on the token at the definition site.

It does this by making the complete panel and its state driven by the URL and the #tab=references hash.

All of the other code related to the clicked token, the global props, etc. is gone.

Test plan

  • Tested this locally by going through different scenarios: opening panel, closing it, clicking on references (in same file, other file), clicking on references inside the opened code blob, etc. See video.

https://user-images.githubusercontent.com/1185253/156393737-6b13cb8c-f68b-4d26-aa46-78d3bcb290e3.mp4

Merge request reports