Skip to content

dev/ci: provide annotation opts as env instead of args

Warren Gifford requested to merge test-reports-in-annotated-cmd into main

Created by: bobheadxi

This change allows us to configure multiple "scrapers" on AnnotatedCmd more easily by passing the annotation options as an env var, ANNOTATE_OPTS, rather than positional arguments. No external API or behavioural changes in this PR.

The next step will be to add a scraper and option builder for test reports uploads (https://github.com/sourcegraph/sourcegraph/pull/31969) as part of https://github.com/sourcegraph/sourcegraph/issues/31409

Don't mind the branch name, I forgot to change it 😅

Test plan

  1. add demo failure: https://github.com/sourcegraph/sourcegraph/commit/c1350d83ffc62984a5d4a0d68c1f5629152681b0
  2. verify annotations still render: https://buildkite.com/sourcegraph/sourcegraph/builds/134284
image

Merge request reports