Skip to content

web: Fix layout for home page panels and logged out content

Warren Gifford requested to merge ps/fix-home-page-layout into main

Created by: philipp-spiess

Fixes https://github.com/sourcegraph/sourcegraph/issues/31560

The layout for the home page panels and logged out content has quite a few requirements:

  • It needs to be able to grow up to 90% of the viewport on large pages since some of the pervious queries might get big.
  • It should have at least the same width as the search bar, otherwise it looks odd
    • This was not working as expected currently and it was possible to get the layout into a stage where the content would collapse below that.
  • It needs to support smaller screens by being contained within the screen and not requiring vertical scroll.

This diff fixes the layout to support all three properties by making the panels section behave similarly than the search bar.

Additionally, this fixes responsive use by not capping the layout width to 90% (see Chromatic)

Test plan

Prev Next
Cloud logged out cloud-loggedout-prev cloud-loggedout-new
Cloud logged in cloud-loggedin-prev cloud-loggedin-new
On-prem null state onprem-loggedin-prev-null onprem-loggedin-new-null
On-prem saved search onprem-loggedin-prev-search-results onprem-loggedin-new-search-results

Merge request reports