Skip to content

Remove Apollo client warning by querying id of repo/commit

Warren Gifford requested to merge mrn/query-ids-fuzzy-finder into main

Created by: mrnugget

I've seen Apollo warn me about not being able to properly cache/merge repository in its internal cache because it can't find an identifier.

This queries the ID of repository and commit, which don't produce a performance hit here.

screenshot_2022-02-21_10 50 35@2x

Test plan

  • Browse repository locally in Sourcegraph, open reference panel, see warning
  • Fix issue by adding ids to the query
  • Do the same thing as in step 1, get no warning

Merge request reports