Skip to content

sg: refactor process output piping to use errgroups

Warren Gifford requested to merge sg-hacking-hour/pipe-output into main

Created by: mrnugget

This confirms that #30529 (closed) is fixed and makes it a bit less error prone.

Test plan

  • Change cmd/github-proxy/github_proxy.go to print 10M characters with log15.Warn, run cd dev/sg && go run . run github-proxy
  • Change cmd/github-proxy/github_proxy.go to print single characters without newlines, run cd dev/sg && go run . run github-proxy

Merge request reports