Skip to content

Revert "gitserver: Rename NoTimeout to EnableTimeout"

Warren Gifford requested to merge revert-30884-ig/intuitive-gitserver into main

Created by: indradhanush

Reverts sourcegraph/sourcegraph#30884

Reverting because this comment by @keegancsmith makes sense:

The purpose of double negative is the default value in go is false. This makes it much easier to rollout changes when adding a field/etc. Also I think it's nice when you structure your fields such that the go zero values are the defaults.

@indradhanush Reading this PR it looks like we now never set EnableTimeout. Doesn't this imlpy now that we never have a timeout set which is breaking existing behaviour? IE before chris's PR every git exec command had a timeout. Now we don't have that...

Closes #31036 (closed).

Merge request reports