Skip to content

Chromatic: Disable dark theme for most stories

Warren Gifford requested to merge tr/disable-dark-mode-chromatic into main

Created by: umpox

Description

This PR:

  • Disables Chromatic dark theme snapshots for all stories by default
  • Ensures Wildcard and Global style stories preserve their dark theme snapshots

Context

  1. We're trying to reduce the amount of Chromatic snapshots we create to ensure we can reduce cost.
  2. We've had some discussions that we don't get a significant benefit out of duplicating each snapshot in dark theme. Most regressions tend to be layout related rather than due to colors.

Future

We still want some level of theme snapshots across pages, but it will scale better through using Percy for full page snapshots. Percy should also be used like this for any future themes we introduce to the webapp (e.g. high contrast).

The Frontend Platform team will investigate how best we can do that in an upcoming RFC.

Merge request reports

Loading