Skip to content

Hoverify search results for code intel

Warren Gifford requested to merge tjk/search-results-hoverifier into main

Created by: tjkandala

Context: https://sourcegraph.slack.com/archives/C01C3NCGD40/p1642679312056800

https://user-images.githubusercontent.com/37420160/150884484-07058318-8aec-4cc6-b8b0-3aafcc0db2a4.mov

Only enabled for search notebooks currently, it is easy to add to general search results if this doesn't affect performance.

It's rough right now (no test/story updates, left some TODO comments that should be easy to resolve other than perf concerns that need to be validated), but this is very promising. I'll return to this next week cc @novoselrok you can work on this branch in the meantime if needed!

I'll also document this stuff (UI side of code intel/extensions) next week so it's easier to maintain

Test plan

  • Create a new notebook
  • Add a query block and run it with a query
    • Hover over the search results
    • You should see the code intel popover appear
  • Add a file block
    • Hover over the code snippet
    • You should see the code intel popover appear

Merge request reports