Gitolite special chars (!2972) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge bl/gitolite-special-chars into master Mar 25, 2019

Created by: beyang

Fixes https://github.com/sourcegraph/issues-uber/issues/151. This PR is best reviewed commit by commit at first, but there are inline comments about the mock/DI patterns in the overall PR.

I tried adopting dependency injection in two of the packages, along with using gomock to generate mocks/stubs for unit tests. DI (the way it is implemented here) results in a little bit more verbosity and indirection complexity, but I think it's worth it for the stronger unit tests. I also tried to write the tests in a way such that the boilerplate could be codegen'd at some point in the future.

Gitolite special chars

Merge request reports