Skip to content

Wildcard: `<Modal />` migration

Warren Gifford requested to merge tr/wildcard-modal-migration into main

Created by: umpox

Closes https://github.com/sourcegraph/sourcegraph/issues/27698 Closes https://github.com/sourcegraph/sourcegraph/issues/27696

Description

This PR is a complete migration of our old Modal styles and components to use the new Wildcard Modal that is introduced in this PR: https://github.com/sourcegraph/sourcegraph/pull/29468

  • All @reach/dialog usage has been updated to use the Wildcard Modal component. Props have been updated. Styles have been unduplicated.
  • All reactstrap Modal usage has been updated to use the Wildcard Modal component.
  • All Bootstrap modal classes (such as modal-body, modal-title and so on) have been removed. We no longer depend on Bootstrap for our modals
  • Imports have been updated to reflect above changes

I've gone through and checked the UI for any components that applied additional styles. Most are fine, left some comments below with some minor UI changes.

Merge request reports