Skip to content

Symbols: continue parsing on error

Warren Gifford requested to merge symbols-continue-on-error into master

Created by: chrismwendt

Previously, when ctags crashed while parsing, the symbols service would bail on that repository and return the error. The same error would occur the next time a query was made on that repository again. I was only able to repro on my macOS, not on Sourcegraph.com. To repro, go to http://localhost:3080/github.com/mas-cli/mas (and click on the symbols sidebar)

23:35:07 symbols | ERROR Closing failed parser and creating a new one., path: Carthage/Checkouts/Commandant/Carthage/Checkouts/Nimble/Sources/NimbleObjectiveC/DSL.h, error: unexpected EOF from ctags 23:35:07 symbols | ERROR Error parsing symbols., repo: github.com/mas-cli/mas, commitID: 262dacade307bb592f50371c0fab185a0dd6ff7b, path: Carthage/Checkouts/Commandant/Carthage/Checkouts/Nimble/Sources/NimbleObjectiveC/DSL.h, dataSize: 15233, error: unexpected EOF from ctags

Now, when ctags crashes, the symbols service will continue on to the next file.

Upstream bug https://github.com/universal-ctags/ctags/issues/2053

Merge request reports