Skip to content

Use returned IDs for EnqueueActionJobsForQuery

Warren Gifford requested to merge cc/webhooks-1 into main

Created by: camdencheek

These tests have a bunch of hard-coded IDs. IDs should ideally be pretty opaque, so having tests that guess what ID the database inserts things with is problematic. These tests are brittle because of that, and they have a bunch of magic numbers that make them difficult to understand. On top of that, it makes it impossible to run these tests in transactions.

To start fixing that, this PR makes EnqueueActionJobsForQuery return the list of jobs that it enqueued so we can use the IDs of those jobs later in the test. There will be a couple of followup PRs doing similar things for other store methods.

Merge request reports