Skip to content

codeintel: Fix missing `done(err)` call in symbols

Warren Gifford requested to merge fix-symbols-done into main

Created by: chrismwendt

The symbols service in prod is stalled right now because it's not calling done(err) and releasing the semaphore, which is causing all new search request goroutines to get stuck waiting for the semaphore.

This bug has existed for years, and only now shows up because #27932 is causing errors on big repos.

Either of these will fix the stalled symbols service:

  • Merge and deploy this PR
  • Deploy #27989 (merged, but not deployed yet)

Merge request reports