Skip to content

batches: manually trigger workspaces preview, improvements

Warren Gifford requested to merge kr/manual-workspaces-preview into main

Created by: courier-new

A number of improvements to the "Create" screen centered around the workspaces preview here:

https://user-images.githubusercontent.com/8942601/141378001-61dda8cc-8149-4958-823c-d8b16c0c23c5.mov

  • Workspaces preview is manually triggered
    • Prompt is shown whenever valid batch spec code has not been previewed
    • Heavy computation (validation) is still debounced
    • Prominent error messages when anything prevents preview
  • Numerous code organizational improvements
    • The mega mutation to submit the batch spec is broken down into smaller, smarter, more readable requests
    • "Islands" of business logic related to handling the editor code, submitting the batch spec, polling for the workspace resolution, etc. are collected into custom hooks
    • More components are broken out of the WorkspacesPreview
    • Comments everywhere!!!
  • Some visual enhancements
    • Workspaces preview is scrollable
    • Prompt from Figma designs
    • Spacing/layout improvements
    • More storybook stories!

Merge request reports

Loading