fix usage of custom location providers in extension API panel views (!2733) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge fix-panels-with-custom-location-providers into master Mar 14, 2019

Created by: sqs

Previously, a TypeScript cast as PanelViewWithComponent resulted in panel views (that used a custom location provider registered with registerLocationProvider) having an incorrectly typed locationProvider value. This meant that using a panel view with a custom location provider would throw a JavaScript error.

Depends on https://github.com/sourcegraph/sourcegraph/pull/1697

https://github.com/sourcegraph/sourcegraph-go/pull/47
https://github.com/sourcegraph/sourcegraph-typescript/pull/132

fix usage of custom location providers in extension API panel views

Merge request reports