Skip to content

GitLab

Explore

Sign in
Register

Primary navigation

Project

S

sourcegraph
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Wiki
- Snippets
- Package registry
- Model registry
- Environments
- Terraform modules
- Incidents
- Value stream analytics
- Model experiments

Snippets Groups Projects

!27087

internal/authz: remove potentially expensive conf check in SubRepoPermsClient

Review changes
Download
Patches
Plain diff

Closed internal/authz: remove potentially expensive conf check in SubRepoPermsClient

remove-conf-check into main

Overview 0
Commits 1
Pipelines 0
Changes 1

Closed internal/authz: remove potentially expensive conf check in SubRepoPermsClient

Warren Giffordrequested to merge

remove-conf-check into main Nov 4, 2021

Overview 0
Commits 1
Pipelines 0
Changes 1

Created by: bobheadxi

Callers should do the check themselves - having it inside SubRepoPermsClient means potentially fetching conf very frequently in tight loops, e.g. when iterating over a set of files for permissions

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Loading

Labels

1

1

Select labels

Manage project labels

Milestone

None

None

None

Time tracking

No estimate or time spent

Participants

There are no commits yet

Push commits to the source branch or add previously merged commits to review them.

Loading